From 8e07c4bf6662751396651defcb4260db4fc880a6 Mon Sep 17 00:00:00 2001
From: Florian Stinglmayr <florian.stinglmayr@proton.me>
Date: Mon, 28 Apr 2025 07:57:19 +0200
Subject: [PATCH] add unit test for old style journal files

---
 lib/src/journal/file.c                |  2 ++
 lib/tests/Journal.230418061507.01.log |  0
 lib/tests/test-journal-file.c         | 18 ++++++++++++++++++
 3 files changed, 20 insertions(+)
 create mode 100644 lib/tests/Journal.230418061507.01.log

diff --git a/lib/src/journal/file.c b/lib/src/journal/file.c
index 8219205..a225e6f 100644
--- a/lib/src/journal/file.c
+++ b/lib/src/journal/file.c
@@ -271,6 +271,8 @@ static EDErrorCode ed_journal_file_load(EDJournalFile *self,
         p->entries = g_list_append(p->entries, entry);
     }
 
+    ret = ed_error_success;
+
 done:
 
     g_clear_object(&file);
diff --git a/lib/tests/Journal.230418061507.01.log b/lib/tests/Journal.230418061507.01.log
new file mode 100644
index 0000000..e69de29
diff --git a/lib/tests/test-journal-file.c b/lib/tests/test-journal-file.c
index 5cbf215..b075b41 100644
--- a/lib/tests/test-journal-file.c
+++ b/lib/tests/test-journal-file.c
@@ -23,6 +23,23 @@ static void test_new_filename(void **state)
     g_clear_object(&file);
 }
 
+static void test_old_filename(void **state)
+{
+    char const *filename = "Journal.230418061507.01.log";
+
+    EDJournalFile *file = ed_journal_file_new();
+    EDErrorCode ret = 0;
+    GError *error = NULL;
+
+    assert_non_null(file);
+
+    ret = ed_journal_file_open(file, filename, &error);
+    assert_int_equal(ret, ed_error_success);
+    assert_null(error);
+
+    g_clear_object(&file);
+}
+
 static void test_valid_load(void **state)
 {
     char const *filename = "Journal.2023-04-18T061507.01.log";
@@ -58,6 +75,7 @@ int main(int ac, char **av)
 {
     static const struct CMUnitTest tests[] = {
         cmocka_unit_test(test_new_filename),
+        cmocka_unit_test(test_old_filename),
         cmocka_unit_test(test_valid_load),
     };