change site to new version number

If a factions expands or retreats into a system we see, we won't pick it up if we remain with old data.

EDPlayerJournal/BGS/Cartographics.cs

@@ -1,10 +1,11 @@
-using System.Linq;
+using System.Text;
-using System.Text;
 using EDPlayerJournal.Entries;
 
 namespace EDPlayerJournal.BGS;
 
 public class Cartographics : Transaction {
+    public Cartographics() { }
+
     public Cartographics(MultiSellExplorationDataEntry e) {
         Entries.Add(e);
     }

EDPlayerJournal/BGS/OrganicData.cs

@@ -4,6 +4,8 @@ using EDPlayerJournal.Entries;
 namespace EDPlayerJournal.BGS;
 
 public class OrganicData : Transaction {
+    public OrganicData() { }
+
     public OrganicData(SellOrganicDataEntry e) {
         Entries.Add(e);
     }
@@ -36,6 +38,8 @@ public class OrganicData : Transaction {
 
     /* Selling organic data only helps the controlling faction, just like
      * selling cartographic data.
+     * 
+     * Right now: Organic data helps no one.
      */
     public override bool OnlyControllingFaction => true;
 }

EDPlayerJournal/BGS/Parsers/MarketBuyParser.cs

@@ -0,0 +1,44 @@
+using EDPlayerJournal.Entries;
+
+namespace EDPlayerJournal.BGS;
+
+internal class MarketBuyParser : ITransactionParserPart {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
+        MarketBuyEntry? entry = e as MarketBuyEntry;
+        if (entry == null) {
+            throw new NotImplementedException();
+        }
+
+        context.BoughtCargo(entry.Type, entry.BuyPrice);
+
+        // We still want the information on buy price for profit,
+        // but if the option is on, we don't care for parsing it
+        // further.
+        // TODO: might be wise to split this parser into two; one for
+        //       determining profit, the other for the BGS information
+        if (options.IgnoreMarketBuy) {
+            return;
+        }
+
+        if (context.StationOwner == null) {
+            transactions.AddIncomplete(
+                new BuyCargo(),
+                "Could not discern the station owner for market buy.",
+                e);
+            return;
+        }
+
+        // Ignore if its a fleet carrier faction.
+        if (string.Compare(context.StationOwner, Factions.FleetCarrier, StringComparison.OrdinalIgnoreCase) == 0 &&
+            options.IgnoreFleetCarrierFaction) {
+            return;
+        }
+
+        transactions.Add(new BuyCargo(entry) {
+            System = context.CurrentSystem,
+            Station = context.CurrentStation,
+            Faction = context.StationOwner,
+            IsLegacy = context.IsLegacy,
+        });
+    }
+}

EDPlayerJournal/BGS/Parsers/MarketSellParser.cs

@@ -0,0 +1,45 @@
+using EDPlayerJournal.Entries;
+
+namespace EDPlayerJournal.BGS;
+
+internal class MarketSellParser : ITransactionParserPart {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
+        long profit = 0;
+
+        if (context.StationOwner == null) {
+            transactions.AddIncomplete(
+                new SellCargo(),
+                "Could not discern the station owner market sell.",
+                e);
+            return;
+        }
+
+        // Ignore if its a fleet carrier faction.
+        if (string.Compare(context.StationOwner, Factions.FleetCarrier, StringComparison.OrdinalIgnoreCase) == 0 &&
+            options.IgnoreFleetCarrierFaction) {
+            return;
+        }
+
+        MarketSellEntry? entry = e as MarketSellEntry;
+        if (entry == null) {
+            throw new NotImplementedException();
+        }
+
+        if (entry.Type == null) {
+            throw new InvalidJournalEntryException("market sell contains no cargo type");
+        }
+
+        if (context.BuyCost.ContainsKey(entry.Type)) {
+            long avg = context.BuyCost[entry.Type];
+            profit = (long)entry.TotalSale - (avg * entry.Count);
+        }
+
+        transactions.Add(new SellCargo(entry) {
+            System = context.CurrentSystem,
+            Station = context.CurrentStation,
+            Faction = context.StationOwner,
+            Profit = profit,
+            IsLegacy = context.IsLegacy,
+        });
+    }
+}

EDPlayerJournal/BGS/Parsers/MultiSellExplorationDataParser.cs

@@ -0,0 +1,33 @@
+using EDPlayerJournal.Entries;
+
+namespace EDPlayerJournal.BGS;
+
+internal class MultiSellExplorationDataParser : ITransactionParserPart {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
+        MultiSellExplorationDataEntry? entry = e as MultiSellExplorationDataEntry;
+        if (entry == null) {
+            throw new NotImplementedException();
+        }
+
+        if (context.StationOwner == null) {
+            transactions.AddIncomplete(
+                new Cartographics(),
+                "Could not discern the station owner for cartographics sell.",
+                e);
+            return;
+        }
+
+        // Ignore if its a fleet carrier faction.
+        if (string.Compare(context.StationOwner, Factions.FleetCarrier, StringComparison.OrdinalIgnoreCase) == 0 &&
+            options.IgnoreFleetCarrierFaction) {
+            return;
+        }
+
+        transactions.Add(new Cartographics(entry) {
+            System = context.CurrentSystem,
+            Station = context.CurrentStation,
+            Faction = context.StationOwner,
+            IsLegacy = context.IsLegacy,
+        });
+    }
+}

EDPlayerJournal/BGS/Parsers/SellExplorationDataParser.cs

@@ -0,0 +1,33 @@
+using EDPlayerJournal.Entries;
+
+namespace EDPlayerJournal.BGS;
+
+internal class SellExplorationDataParser : ITransactionParserPart {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
+        SellExplorationDataEntry? entry = e as SellExplorationDataEntry;
+        if (entry == null) {
+            throw new NotImplementedException();
+        }
+
+        if (context.StationOwner == null) {
+            transactions.AddIncomplete(
+                new Cartographics(),
+                "Could not discern the station owner for cartographics sell.",
+                e);
+            return;
+        }
+
+        // Ignore if its a fleet carrier faction.
+        if (string.Compare(context.StationOwner, Factions.FleetCarrier, StringComparison.OrdinalIgnoreCase) == 0 &&
+            options.IgnoreFleetCarrierFaction) {
+            return;
+        }
+
+        transactions.Add(new Cartographics(entry) {
+            System = context.CurrentSystem,
+            Station = context.CurrentStation,
+            Faction = context.StationOwner,
+            IsLegacy = context.IsLegacy,
+        });
+    }
+}

EDPlayerJournal/BGS/Parsers/SellOrganicDataParser.cs

@@ -0,0 +1,38 @@
+using EDPlayerJournal.Entries;
+
+namespace EDPlayerJournal.BGS;
+
+internal class SellOrganicDataParser : ITransactionParserPart {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
+        // If exo biology is ignored, simply do nothing
+        if (options.IgnoreExoBiology) {
+            return;
+        }
+
+        SellOrganicDataEntry? entry = e as SellOrganicDataEntry;
+        if (entry == null) {
+            throw new NotImplementedException();
+        }
+
+        if (context.StationOwner == null) {
+            transactions.AddIncomplete(
+                new OrganicData(),
+                "Could not discern the station owner for organic data sell.",
+                e);
+            return;
+        }
+
+        // Ignore if its a fleet carrier faction.
+        if (string.Compare(context.StationOwner, Factions.FleetCarrier, StringComparison.OrdinalIgnoreCase) == 0 &&
+            options.IgnoreFleetCarrierFaction) {
+            return;
+        }
+
+        transactions.Add(new OrganicData(entry) {
+            System = context.CurrentSystem,
+            Station = context.CurrentStation,
+            Faction = context.StationOwner,
+            IsLegacy = context.IsLegacy,
+        });
+    }
+}

EDPlayerJournal/BGS/Parsers/SupercruiseDestinationDropParser.cs

@@ -0,0 +1,14 @@
+using EDPlayerJournal.Entries;
+
+namespace EDPlayerJournal.BGS.Parsers;
+
+internal class SupercruiseDestinationDropParser : ITransactionParserPart {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
+        SupercruiseDestinationDropEntry? drop = entry as SupercruiseDestinationDropEntry;
+        if (drop == null || drop.Type == null) {
+            return;
+        }
+
+        context.CurrentInstanceType = drop.Type;
+    }
+}

EDPlayerJournal/BGS/TransactionParser.cs

@@ -1,220 +1,33 @@
-using EDPlayerJournal;
+using EDPlayerJournal.BGS.Parsers;
 using EDPlayerJournal.Entries;
 
 namespace EDPlayerJournal.BGS;
 
-internal class TransactionParserContext {
+public class TransactionParserOptions {
-    public string? CurrentSystem { get; set; }
+    /// <summary>
-    public ulong? CurrentSystemAddress { get; set; }
+    /// Whether to ignore exo biology. It does not contribute to BGS, so this
-    public string? CurrentStation { get; set; }
+    /// is true per default.
-    public string? ControllingFaction { get; set; }
+    /// </summary>
-
+    public bool IgnoreExoBiology { get; set; } = true;
-    public bool IsOnFoot { get; set; } = false;
-
-    public string? LastRecordedAwardingFaction { get; set; }
-
-    public ulong? HighestCombatBond { get; set; }
-
-    public bool HaveSeenCapShip { get; set; } = false;
-    public bool HaveSeenCaptain { get; set; } = false;
-    public bool HaveSeenSpecOps { get; set; } = false;
-    public bool HaveSeenCorrespondent { get; set; } = false;
 
     /// <summary>
-    /// Returns true if the current session is legacy
+    /// Whether to ignore influence support. Usually one only cares about the
+    /// primary faction for the influence.
     /// </summary>
-    public bool IsLegacy { get; set; } = false;
+    public bool IgnoreInfluenceSupport { get; set; } = false;
 
     /// <summary>
-    /// How many on foot kills were done.
+    /// Whether to ignore market buy. Buying from a market gives a small amount
+    /// of INF if it is sold to a high demand market, but generally one buys from
+    /// a market to aid the faction the stuff is being sold to. So allow it to be
+    /// disabled.
     /// </summary>
-    public ulong OnFootKills { get; set; } = 0;
+    public bool IgnoreMarketBuy { get; set; } = false;
 
     /// <summary>
-    /// How many ship kills were done.
+    /// Whether we should ignore things done for the fleet carrier faction.
     /// </summary>
-    public ulong ShipKills { get; set; } = 0;
+    public bool IgnoreFleetCarrierFaction { get; set; } = true;
-
-    /// <summary>
-    /// Thargoid scouts killed
-    /// </summary>
-    public ulong ThargoidScoutKills { get; set; } = 0;
-
-    /// <summary>
-    /// Thargoid interceptor kills
-    /// </summary>
-    public ulong ThargoidInterceptorKills { get; set; } = 0;
-
-    /// <summary>
-    /// Whether we have seen an AX warzone NPC talk to us with ReceiveText
-    /// </summary>
-    public bool HaveSeenAXWarzoneNPC { get; set; } = false;
-
-    /// <summary>
-    /// A list of accepted missions index by their mission ID
-    /// </summary>
-    public Dictionary<ulong, Mission> AcceptedMissions { get; } = new();
-    public Dictionary<ulong, Location> AcceptedMissionLocation { get; } = new();
-    /// <summary>
-    /// A way to lookup a system by its system id
-    /// </summary>
-    public Dictionary<ulong, string> SystemsByID { get; } = new();
-    /// <summary>
-    /// A list of factions present in the given star system
-    /// </summary>
-    public Dictionary<string, List<Faction>> SystemFactions { get; } = new();
-    /// <summary>
-    /// To which faction a given named NPC belonged to.
-    /// </summary>
-    public Dictionary<string, string> NPCFaction { get; } = new();
-    /// <summary>
-    /// Buy costs for a given commodity
-    /// </summary>
-    public Dictionary<string, long> BuyCost = new();
-
-    public void DiscernCombatZone(TransactionList transactions, Entry e) {
-        string? grade = CombatZones.DifficultyLow;
-        string cztype;
-        ulong highest = HighestCombatBond ?? 0;
-        string? faction = LastRecordedAwardingFaction;
-
-        if (HighestCombatBond == null &&
-            LastRecordedAwardingFaction == null &&
-            HaveSeenAXWarzoneNPC == false) {
-            return;
-        }
-
-        if (OnFootKills > 0 || IsOnFoot == true) {
-            cztype = CombatZones.GroundCombatZone;
-            // High on foot combat zones have enforcers that bring 80k a pop
-            if (highest >= 60000) {
-                grade = CombatZones.DifficultyHigh;
-            } else if (highest >= 30000) {
-                // In medium conflict zones, the enforcers are worth 30k
-                grade = CombatZones.DifficultyMedium;
-            } else {
-                grade = CombatZones.DifficultyLow;
-            }
-        } else if (ShipKills > 0 && !IsOnFoot) {
-            // Ship combat zones can be identified by the amount of kills
-            if (ShipKills > 20) {
-                grade = CombatZones.DifficultyHigh;
-            } else if (ShipKills > 10) {
-                grade = CombatZones.DifficultyMedium;
-            }
-
-            // Cap ship, means a high conflict zone
-            if (HaveSeenCapShip) {
-                grade = CombatZones.DifficultyHigh;
-            } else {
-                int warzoneNpcs = new List<bool>() { HaveSeenCaptain, HaveSeenCorrespondent, HaveSeenSpecOps }
-                                    .Where(x => x == true)
-                                    .Count()
-                                    ;
-
-                if (warzoneNpcs >= 1 && grade == CombatZones.DifficultyLow) {
-                    grade = CombatZones.DifficultyMedium;
-                }
-            }
-            cztype = CombatZones.ShipCombatZone;
-        } else if ((ThargoidScoutKills > 0 && ThargoidInterceptorKills > 0) ||
-                   HaveSeenAXWarzoneNPC == true) {
-            // Could be a thargoid combat zones if interceptors and scouts are there
-            cztype = CombatZones.AXCombatZone;
-            // Still unknown
-            grade = null;
-        } else {
-            transactions.AddIncomplete(new CombatZone(), "Failed to discern combat zone type", e);
-            return;
-        }
-
-        CombatZone zone = new CombatZone() {
-            System = CurrentSystem,
-            Faction = faction,
-            IsLegacy = IsLegacy,
-            Grade = grade,
-            Type = cztype,
-            // Sad truth is, if HaveSeenXXX is false, we just don't know for certain
-            CapitalShip = HaveSeenCapShip ? true : null,
-            SpecOps = HaveSeenSpecOps ? true : null,
-            Correspondent = HaveSeenCorrespondent ? true : null,
-            Captain = HaveSeenCaptain ? true : null,
-        };
-        zone.Entries.Add(e);
-        transactions.Add(zone);
-    }
-
-    public void RecordCombatBond(FactionKillBondEntry e) {
-        if (HighestCombatBond == null || e.Reward > HighestCombatBond) {
-            HighestCombatBond = e.Reward;
-        }
-
-        LastRecordedAwardingFaction = e.AwardingFaction;
-
-        if (IsOnFoot) {
-            ++OnFootKills;
-        } else {
-            ++ShipKills;
-        }
-    }
-
-    public void ResetCombatZone() {
-        HighestCombatBond = null;
-        HaveSeenCapShip = false;
-        HaveSeenCaptain = false;
-        HaveSeenCorrespondent = false;
-        HaveSeenSpecOps = false;
-        LastRecordedAwardingFaction = null;
-        OnFootKills = 0;
-        ShipKills = 0;
-        ThargoidInterceptorKills = 0;
-        ThargoidScoutKills = 0;
-        HaveSeenAXWarzoneNPC = false;
-    }
-
-    public void BoughtCargo(string? cargo, long? cost) {
-        if (cargo == null || cost == null) {
-            return;
-        }
-
-        BuyCost[cargo] = cost.Value;
-    }
-
-    public List<Faction>? GetFactions(string? system) {
-        if (system == null || !SystemFactions.ContainsKey(system)) {
-            return null;
-        }
-
-        return SystemFactions[system];
-    }
-
-    public void MissionAccepted(MissionAcceptedEntry? entry) {
-        if (entry == null) {
-            return;
-        }
-
-        MissionAccepted(entry.Mission);
-    }
-
-    public void MissionAccepted(Mission? mission) {
-        if (CurrentSystem == null || CurrentSystemAddress == null) {
-            throw new Exception("Mission accepted without knowing where.");
-        }
-
-        if (mission == null) {
-            throw new Exception("Mission is null");
-        }
-
-        AcceptedMissions.TryAdd(mission.MissionID, mission);
-
-        Location location = new() {
-            StarSystem = CurrentSystem,
-            SystemAddress = CurrentSystemAddress.Value,
-            Station = (CurrentStation ?? ""),
-        };
-
-        AcceptedMissionLocation.TryAdd(mission.MissionID, location);
-    }
 }
 
 public class TransactionList : List<Transaction> {
@@ -223,29 +36,13 @@ public class TransactionList : List<Transaction> {
     }
 }
 
-internal interface TransactionParserPart{
-    /// <summary>
-    /// Parse a given entry of the entry type specified when declaring to implement this
-    /// interface. You must add your transaction to the passed list in case you did have
-    /// enough information to parse one or more. You may update the parser context
-    /// with new information in case the entry yielded new information.
-    /// Throw an exception if there was an error or a malformed entry. If you have an
-    /// incomplete entry, i.e. not enough information to complete one, add an
-    /// IncompleteTransaction to the list
-    /// </summary>
-    /// <param name="entry">The entry to parse</param>
-    /// <param name="context">Parsing context that may contain useful information</param>
-    /// <param name="transactions">List of parsed transactions</param>
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions);
-}
-
 /// <summary>
 /// The location parser only updates the context with useful information, and does not
 /// by itself generate any transactions. Location is the best information gatherer here
 /// as we are getting controlling faction, system factions, address and station name.
 /// </summary>
-internal class LocationParser : TransactionParserPart {
+internal class LocationParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         LocationEntry? entry = e as LocationEntry;
         if (entry == null) {
             throw new NotImplementedException();
@@ -268,15 +65,20 @@ internal class LocationParser : TransactionParserPart {
             context.CurrentStation = entry.StationName;
         }
 
-        if (!context.SystemFactions.ContainsKey(entry.StarSystem) &&
+        if (!string.IsNullOrEmpty(entry.StationFaction)) {
-            entry.SystemFactions != null && entry.SystemFactions.Count > 0) {
+            context.StationOwner = entry.StationFaction;
+        } else {
+            context.StationOwner = null;
+        }
+
+        if (entry.SystemFactions != null && entry.SystemFactions.Count > 0) {
             context.SystemFactions[entry.StarSystem] = entry.SystemFactions;
         }
     }
 }
 
-internal class FSDJumpParser : TransactionParserPart {
+internal class FSDJumpParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         FSDJumpEntry? entry = e as FSDJumpEntry;
         if (entry == null) {
             throw new NotImplementedException();
@@ -292,6 +94,8 @@ internal class FSDJumpParser : TransactionParserPart {
         context.DiscernCombatZone(transactions, e);
         context.ResetCombatZone();
 
+        context.LeftInstance();
+
         context.CurrentSystem = entry.StarSystem;
         context.CurrentSystemAddress = entry.SystemAddress;
 
@@ -301,15 +105,14 @@ internal class FSDJumpParser : TransactionParserPart {
             context.ControllingFaction = entry.SystemFaction;
         }
 
-        if (!context.SystemFactions.ContainsKey(entry.StarSystem) &&
+        if (entry.SystemFactions != null && entry.SystemFactions.Count > 0) {
-            entry.SystemFactions != null && entry.SystemFactions.Count > 0) {
             context.SystemFactions[entry.StarSystem] = entry.SystemFactions;
         }
     }
 }
 
-internal class DockedParser : TransactionParserPart {
+internal class DockedParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         DockedEntry? entry = e as DockedEntry;
         if (entry == null) {
             throw new NotImplementedException();
@@ -325,7 +128,7 @@ internal class DockedParser : TransactionParserPart {
         context.SystemsByID.TryAdd(entry.SystemAddress.Value, entry.StarSystem);
 
         if (!string.IsNullOrEmpty(entry.StationFaction)) {
-            context.ControllingFaction = entry.StationFaction;
+            context.StationOwner = entry.StationFaction;
         }
 
         if (!string.IsNullOrEmpty(entry.StationName)) {
@@ -338,8 +141,8 @@ internal class DockedParser : TransactionParserPart {
 /// With ship targeted we might find out to which faction a given NPC belonged. This is
 /// useful later when said NPC gets killed or murdered.
 /// </summary>
-internal class ShipTargetedParser : TransactionParserPart {
+internal class ShipTargetedParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         ShipTargetedEntry? entry = e as ShipTargetedEntry;
         if (entry == null) {
             throw new NotImplementedException();
@@ -373,8 +176,8 @@ internal class ShipTargetedParser : TransactionParserPart {
 /// Commit crime can result in a transaction, especially if the crime committed is
 /// murder.
 /// </summary>
-internal class CommitCrimeParser : TransactionParserPart {
+internal class CommitCrimeParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         CommitCrimeEntry? entry = e as CommitCrimeEntry;
         if (entry == null) {
             throw new NotImplementedException();
@@ -429,8 +232,8 @@ internal class CommitCrimeParser : TransactionParserPart {
     }
 }
 
-internal class MissionsParser : TransactionParserPart {
+internal class MissionsParser : ITransactionParserPart {
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         MissionsEntry? missions = entry as MissionsEntry;
 
         if (missions == null) {
@@ -458,8 +261,8 @@ internal class MissionsParser : TransactionParserPart {
     }
 }
 
-internal class MissionAcceptedParser : TransactionParserPart {
+internal class MissionAcceptedParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         MissionAcceptedEntry? entry = e as MissionAcceptedEntry;
         if (entry == null) {
             throw new NotImplementedException();
@@ -484,15 +287,15 @@ internal class MissionAcceptedParser : TransactionParserPart {
     }
 }
 
-internal class MissionCompletedParser : TransactionParserPart {
+internal class MissionCompletedParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         MissionCompletedEntry? entry = e as MissionCompletedEntry;
         if (entry == null || entry.Mission == null) {
             throw new NotImplementedException();
         }
 
-        Mission? mission = null;
+        Mission? mission;
-        Location? accepted_location = null;
+        Location? accepted_location;
         string? target_faction_name = entry.Mission.TargetFaction;
         string? source_faction_name = entry.Mission.Faction;
 
@@ -577,6 +380,10 @@ internal class MissionCompletedParser : TransactionParserPart {
                 } else if (string.Compare(faction, source_faction_name, true) != 0 ||
                     (string.Compare(faction, source_faction_name) == 0 && 
                      system_address != accepted_location.SystemAddress)) {
+                    // Whether we ignore influence support
+                    if (options.IgnoreInfluenceSupport) {
+                        continue;
+                    }
                     // Source or target faction are different, and/or the system
                     // differs. Sometimes missions go to different systems but to
                     // the same faction.
@@ -595,11 +402,11 @@ internal class MissionCompletedParser : TransactionParserPart {
     }
 }
 
-internal class MissionFailedParser : TransactionParserPart {
+internal class MissionFailedParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
-        Mission? mission = null;
+        Mission? mission;
-        Location? accepted_location = null;
+        Location? accepted_location;
-        string? accepted_system = null;
+        string? accepted_system;
 
         MissionFailedEntry? entry = e as MissionFailedEntry;
         if (entry == null) {
@@ -650,56 +457,8 @@ internal class MissionFailedParser : TransactionParserPart {
     }
 }
 
-internal class SellExplorationDataParser : TransactionParserPart {
+internal class RedeemVoucherParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
-        SellExplorationDataEntry? entry = e as SellExplorationDataEntry;
-        if (entry == null) {
-            throw new NotImplementedException();
-        }
-
-        transactions.Add(new Cartographics(entry) {
-            System = context.CurrentSystem,
-            Station = context.CurrentStation,
-            Faction = context.ControllingFaction,
-            IsLegacy = context.IsLegacy,
-        });
-    }
-}
-
-internal class SellOrganicDataParser : TransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
-        SellOrganicDataEntry? entry = e as SellOrganicDataEntry;
-        if (entry == null) {
-            throw new NotImplementedException();
-        }
-
-        transactions.Add(new OrganicData(entry) {
-            System = context.CurrentSystem,
-            Station = context.CurrentStation,
-            Faction = context.ControllingFaction,
-            IsLegacy = context.IsLegacy,
-        });
-    }
-}
-
-internal class MultiSellExplorationDataParser : TransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
-        MultiSellExplorationDataEntry? entry = e as MultiSellExplorationDataEntry;
-        if (entry == null) {
-            throw new NotImplementedException();
-        }
-
-        transactions.Add(new Cartographics(entry) {
-            System = context.CurrentSystem,
-            Station = context.CurrentStation,
-            Faction = context.ControllingFaction,
-            IsLegacy = context.IsLegacy,
-        });
-    }
-}
-
-internal class RedeemVoucherParser : TransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
         RedeemVoucherEntry? entry = e as RedeemVoucherEntry;
         if (entry == null) {
             throw new NotImplementedException();
@@ -755,86 +514,56 @@ internal class RedeemVoucherParser : TransactionParserPart {
     }
 }
 
-internal class SellMicroResourcesParser : TransactionParserPart {
+internal class SellMicroResourcesParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         SellMicroResourcesEntry? entry = e as SellMicroResourcesEntry;
         if (entry == null) {
             throw new NotImplementedException();
         }
 
+        if (context.StationOwner == null) {
+            transactions.AddIncomplete(
+                new SellMicroResources(),
+                "Could not discern the station owner for micro resources sell.",
+                e);
+            return;
+        }
+
         transactions.Add(new SellMicroResources(entry) {
             System = context.CurrentSystem,
             Station = context.CurrentStation,
-            Faction = context.ControllingFaction,
+            Faction = context.StationOwner,
             IsLegacy = context.IsLegacy,
         });
     }
 }
 
-internal class SearchAndRescueParser : TransactionParserPart {
+internal class SearchAndRescueParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         SearchAndRescueEntry? entry = e as SearchAndRescueEntry;
         if (entry == null) {
             throw new NotImplementedException();
         }
 
+        if (context.StationOwner == null) {
+            transactions.AddIncomplete(
+                new OrganicData(),
+                "Could not discern the station owner for S&R operations.",
+                e);
+            return;
+        }
+
         transactions.Add(new SearchAndRescue(entry) {
-            Faction = context.ControllingFaction,
-            Station = context.CurrentStation,
             System = context.CurrentSystem,
+            Station = context.CurrentStation,
+            Faction = context.StationOwner,
             IsLegacy = context.IsLegacy,
         });
     }
 }
 
-internal class MarketBuyParser : TransactionParserPart {
+internal class FactionKillBondParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
-        MarketBuyEntry? entry = e as MarketBuyEntry;
-        if (entry == null) {
-            throw new NotImplementedException();
-        }
-
-        context.BoughtCargo(entry.Type, entry.BuyPrice);
-
-        transactions.Add(new BuyCargo(entry) {
-            Faction = context.ControllingFaction,
-            Station = context.CurrentStation,
-            System = context.CurrentSystem,
-            IsLegacy = context.IsLegacy,
-        });
-    }
-}
-
-internal class MarketSellParser : TransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
-        long profit = 0;
-
-        MarketSellEntry? entry = e as MarketSellEntry;
-        if (entry == null) {
-            throw new NotImplementedException();
-        }
-
-        if (entry.Type == null) {
-            throw new InvalidJournalEntryException("market sell contains no cargo type");
-        }
-
-        if (context.BuyCost.ContainsKey(entry.Type)) {
-            long avg = context.BuyCost[entry.Type];
-            profit = (long)entry.TotalSale - (avg * entry.Count);
-        }
-
-        transactions.Add(new SellCargo(entry) {
-            Faction = context.ControllingFaction,
-            Station = context.CurrentStation,
-            System = context.CurrentSystem,
-            Profit = profit,
-            IsLegacy = context.IsLegacy,
-        });
-    }
-}
-
-internal class FactionKillBondParser : TransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
         FactionKillBondEntry? entry = e as FactionKillBondEntry;
         if (entry == null) {
             throw new NotImplementedException();
@@ -866,8 +595,8 @@ internal class FactionKillBondParser : TransactionParserPart {
     }
 }
 
-internal class EmbarkDisembarkParser : TransactionParserPart {
+internal class EmbarkDisembarkParser : ITransactionParserPart {
-    public void Parse(Entry e, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry e, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         if (e.Is(Events.Embark)) {
             context.IsOnFoot = false;
         } else if (e.Is(Events.Disembark)) {
@@ -876,24 +605,28 @@ internal class EmbarkDisembarkParser : TransactionParserPart {
     }
 }
 
-internal class SupercruiseEntryParser : TransactionParserPart {
+internal class SupercruiseEntryParser : ITransactionParserPart {
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         // After a super cruise entry we are no longer on foot.
         context.IsOnFoot = false;
         context.DiscernCombatZone(transactions, entry);
         context.ResetCombatZone();
+        // Supercruise entry means you left the current local instance
+        context.LeftInstance();
     }
 }
 
-internal class ShutdownParser : TransactionParserPart {
+internal class ShutdownParser : ITransactionParserPart {
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         context.DiscernCombatZone(transactions, entry);
         context.ResetCombatZone();
+        // Shutdown (logout) means you left the instance
+        context.LeftInstance();
     }
 }
 
-internal class CapShipBondParser : TransactionParserPart {
+internal class CapShipBondParser : ITransactionParserPart {
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         if (entry.GetType() != typeof(CapShipBondEntry)) {
             return;
         }
@@ -902,8 +635,8 @@ internal class CapShipBondParser : TransactionParserPart {
     }
 }
 
-internal class FileHeaderParser : TransactionParserPart {
+internal class FileHeaderParser : ITransactionParserPart {
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         FileHeaderEntry? fileheader = entry as FileHeaderEntry;
 
         if (fileheader == null) {
@@ -914,8 +647,8 @@ internal class FileHeaderParser : TransactionParserPart {
     }
 }
 
-internal class ReceiveTextParser : TransactionParserPart {
+internal class ReceiveTextParser : ITransactionParserPart {
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         ReceiveTextEntry? receivetext = entry as ReceiveTextEntry;
 
         if (receivetext == null) {
@@ -932,23 +665,25 @@ internal class ReceiveTextParser : TransactionParserPart {
     }
 }
 
-internal class DiedParser : TransactionParserPart {
+internal class DiedParser : ITransactionParserPart {
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         // You can't complete a combat zone if you die in it. Others might keep it open
         // for you, but still you will not have completed it unless you jump back in.
         context.ResetCombatZone();
+        // Dying also moves you back to another instance
+        context.LeftInstance();
     }
 }
 
-internal class DropshipDeployParser : TransactionParserPart {
+internal class DropshipDeployParser : ITransactionParserPart {
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         // On drop ship deploy we are now on foot
         context.IsOnFoot = true;
     }
 }
 
-internal class CommanderParser : TransactionParserPart {
+internal class CommanderParser : ITransactionParserPart {
-    public void Parse(Entry entry, TransactionParserContext context, TransactionList transactions) {
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions) {
         // A commander entry happens when you log out, and log back in again
         // for example when switching from Open, to Solo or PG.
         context.DiscernCombatZone(transactions, entry);
@@ -957,7 +692,7 @@ internal class CommanderParser : TransactionParserPart {
 }
 
 public class TransactionParser {
-    private static Dictionary<string, TransactionParserPart> ParserParts { get; } = new()
+    private static Dictionary<string, ITransactionParserPart> ParserParts { get; } = new()
     {
         { Events.CapShipBond, new CapShipBondParser() },
         { Events.Commander, new CommanderParser() },
@@ -986,6 +721,7 @@ public class TransactionParser {
         { Events.SellOrganicData, new SellOrganicDataParser() },
         { Events.ShipTargeted, new ShipTargetedParser() },
         { Events.Shutdown, new ShutdownParser() },
+        { Events.SupercruiseDestinationDrop, new SupercruiseDestinationDropParser() },
         { Events.SupercruiseEntry, new SupercruiseEntryParser() },
     };
 
@@ -1000,7 +736,17 @@ public class TransactionParser {
         return IsRelevant(e.Event);
     }
 
+    /// <summary>
+    /// Parses a list of entries with default options.
+    /// </summary>
+    /// <param name="entries"></param>
+    /// <returns></returns>
     public List<Transaction>? Parse(IEnumerable<Entry> entries) {
+        TransactionParserOptions defaultOptions = new();
+        return Parse(entries, defaultOptions);
+    }
+
+    public List<Transaction>? Parse(IEnumerable<Entry> entries, TransactionParserOptions options) {
         TransactionList transactions = new();
         TransactionParserContext context = new();
 
@@ -1013,8 +759,8 @@ public class TransactionParser {
                 continue;
             }
 
-            TransactionParserPart transactionParserPart = ParserParts[entry.Event];
+            ITransactionParserPart transactionParserPart = ParserParts[entry.Event];
-            transactionParserPart.Parse(entry, context, transactions);
+            transactionParserPart.Parse(entry, context, options, transactions);
         }
 
         return transactions.ToList();

EDPlayerJournal/BGS/TransactionParserContext.cs

@@ -0,0 +1,303 @@
+using EDPlayerJournal.Entries;
+
+namespace EDPlayerJournal.BGS;
+
+internal class TransactionParserContext {
+    /// <summary>
+    /// Name of the current system the player is in.
+    /// </summary>
+    public string? CurrentSystem { get; set; }
+
+    /// <summary>
+    /// 64 bit address of the current system.
+    /// </summary>
+    public ulong? CurrentSystemAddress { get; set; }
+
+    /// <summary>
+    /// Controlling faction of the current system.
+    /// </summary>
+    public string? ControllingFaction { get; set; }
+
+    /// <summary>
+    /// Name of the current station the player is docked at.
+    /// </summary>
+    public string? CurrentStation { get; set; }
+
+    /// <summary>
+    /// Faction that owns the current station.
+    /// </summary>
+    public string? StationOwner { get; set; }
+
+    /// <summary>
+    /// Whether the player is currently on foot, or in an SRV/ship.
+    /// </summary>
+    public bool IsOnFoot { get; set; } = false;
+
+    /// <summary>
+    /// Type of the current instance after a SupercruiseDestinationDropEntry.
+    /// This is null if there is no current instance, or the current instance
+    /// is not known.
+    /// </summary>
+    public string? CurrentInstanceType { get; set; } = null;
+
+    /// <summary>
+    /// Last faction that awarded the player with combat bonds.
+    /// </summary>
+    public string? LastRecordedAwardingFaction { get; set; }
+
+    /// <summary>
+    /// Highest combat bond seen so far.
+    /// </summary>
+    public ulong? HighestCombatBond { get; set; }
+
+    public bool HaveSeenCapShip { get; set; } = false;
+    public bool HaveSeenCaptain { get; set; } = false;
+    public bool HaveSeenSpecOps { get; set; } = false;
+    public bool HaveSeenCorrespondent { get; set; } = false;
+
+    /// <summary>
+    /// Returns true if the current session is legacy
+    /// </summary>
+    public bool IsLegacy { get; set; } = false;
+
+    /// <summary>
+    /// How many on foot kills were done.
+    /// </summary>
+    public ulong OnFootKills { get; set; } = 0;
+
+    /// <summary>
+    /// How many ship kills were done.
+    /// </summary>
+    public ulong ShipKills { get; set; } = 0;
+
+    /// <summary>
+    /// Thargoid scouts killed
+    /// </summary>
+    public ulong ThargoidScoutKills { get; set; } = 0;
+
+    /// <summary>
+    /// Thargoid interceptor kills
+    /// </summary>
+    public ulong ThargoidInterceptorKills { get; set; } = 0;
+
+    /// <summary>
+    /// Whether we have seen an AX warzone NPC talk to us with ReceiveText
+    /// </summary>
+    public bool HaveSeenAXWarzoneNPC { get; set; } = false;
+
+    /// <summary>
+    /// A list of accepted missions index by their mission ID
+    /// </summary>
+    public Dictionary<ulong, Mission> AcceptedMissions { get; } = new();
+    public Dictionary<ulong, Location> AcceptedMissionLocation { get; } = new();
+    /// <summary>
+    /// A way to lookup a system by its system id
+    /// </summary>
+    public Dictionary<ulong, string> SystemsByID { get; } = new();
+    /// <summary>
+    /// A list of factions present in the given star system
+    /// </summary>
+    public Dictionary<string, List<Faction>> SystemFactions { get; } = new();
+    /// <summary>
+    /// To which faction a given named NPC belonged to.
+    /// </summary>
+    public Dictionary<string, string> NPCFaction { get; } = new();
+    /// <summary>
+    /// Buy costs for a given commodity
+    /// </summary>
+    public Dictionary<string, long> BuyCost = new();
+
+    /// <summary>
+    /// Called when the player leaves an instance, either through logout, FSD jump or
+    /// supercruise instance.
+    /// </summary>
+    public void LeftInstance() {
+        CurrentInstanceType = null;
+    }
+
+    public void DiscernCombatZone(TransactionList transactions, Entry e) {
+        string? grade = CombatZones.DifficultyLow;
+        string cztype;
+        ulong highest = HighestCombatBond ?? 0;
+        string? faction = LastRecordedAwardingFaction;
+
+        if (HighestCombatBond == null &&
+            LastRecordedAwardingFaction == null &&
+            HaveSeenAXWarzoneNPC == false &&
+            CurrentInstanceType == null) {
+            return;
+        }
+
+        if (OnFootKills > 0 || IsOnFoot == true) {
+            cztype = CombatZones.GroundCombatZone;
+            // High on foot combat zones have enforcers that bring 80k a pop
+            if (highest >= 60000) {
+                grade = CombatZones.DifficultyHigh;
+            } else if (highest >= 30000) {
+                // In medium conflict zones, the enforcers are worth 30k
+                grade = CombatZones.DifficultyMedium;
+            } else {
+                grade = CombatZones.DifficultyLow;
+            }
+        } else if (CurrentInstanceType != null) {
+            if (!Instances.IsWarzone(CurrentInstanceType)) {
+                return;
+            }
+            if (LastRecordedAwardingFaction == null && 
+                Instances.IsHumanWarzone(CurrentInstanceType)) {
+                transactions.AddIncomplete(new CombatZone(), 
+                    "Could not discern for whom you fought for, " +
+                    "as it seems you haven't killed anyone in the ship combat zone.",
+                    e);
+                return;
+            }
+            // If we have information about the current instance being a warship use that
+            // information to determine the warzone.
+            if (Instances.IsInstance(CurrentInstanceType, Instances.WarzoneLow)) {
+                cztype = CombatZones.ShipCombatZone;
+                grade = CombatZones.DifficultyLow;
+            } else if (Instances.IsInstance(CurrentInstanceType, Instances.WarzoneMedium)) {
+                cztype = CombatZones.ShipCombatZone;
+                grade = CombatZones.DifficultyMedium;
+            } else if (Instances.IsInstance(CurrentInstanceType, Instances.WarzoneHigh)) {
+                cztype = CombatZones.ShipCombatZone;
+                grade = CombatZones.DifficultyHigh;
+            } else if (Instances.IsInstance(CurrentInstanceType, Instances.WarzoneThargoidLow)) {
+                cztype = CombatZones.AXCombatZone;
+                grade = CombatZones.DifficultyLow;
+            } else if (Instances.IsInstance(CurrentInstanceType, Instances.WarzoneThargoidMedium)) {
+                cztype = CombatZones.AXCombatZone;
+                grade = CombatZones.DifficultyMedium;
+            } else if (Instances.IsInstance(CurrentInstanceType, Instances.WarzoneThargoidHigh)) {
+                cztype = CombatZones.AXCombatZone;
+                grade = CombatZones.DifficultyHigh;
+            } else if (Instances.IsInstance(CurrentInstanceType, Instances.WarzoneThargoidVeryHigh)) {
+                cztype = CombatZones.AXCombatZone;
+                grade = CombatZones.DifficultyVeryHigh;
+            } else {
+                transactions.AddIncomplete(new CombatZone(),
+                    "Unknown conflict zone difficulty",
+                    e);
+                return;
+            }
+        } else if (ShipKills > 0 && !IsOnFoot) {
+            // Ship combat zones can be identified by the amount of kills
+            if (ShipKills > 20) {
+                grade = CombatZones.DifficultyHigh;
+            } else if (ShipKills > 10) {
+                grade = CombatZones.DifficultyMedium;
+            }
+
+            // Cap ship, means a high conflict zone
+            if (HaveSeenCapShip) {
+                grade = CombatZones.DifficultyHigh;
+            } else {
+                int warzoneNpcs = new List<bool>() { HaveSeenCaptain, HaveSeenCorrespondent, HaveSeenSpecOps }
+                                    .Where(x => x == true)
+                                    .Count()
+                                    ;
+
+                if (warzoneNpcs >= 1 && grade == CombatZones.DifficultyLow) {
+                    grade = CombatZones.DifficultyMedium;
+                }
+            }
+            cztype = CombatZones.ShipCombatZone;
+        } else if ((ThargoidScoutKills > 0 && ThargoidInterceptorKills > 0) ||
+                   HaveSeenAXWarzoneNPC == true) {
+            // Could be a thargoid combat zones if interceptors and scouts are there
+            cztype = CombatZones.AXCombatZone;
+            // Still unknown
+            grade = null;
+        } else {
+            transactions.AddIncomplete(new CombatZone(), "Failed to discern combat zone type", e);
+            return;
+        }
+
+        CombatZone zone = new CombatZone() {
+            System = CurrentSystem,
+            Faction = faction,
+            IsLegacy = IsLegacy,
+            Grade = grade,
+            Type = cztype,
+            // Sad truth is, if HaveSeenXXX is false, we just don't know for certain
+            CapitalShip = HaveSeenCapShip ? true : null,
+            SpecOps = HaveSeenSpecOps ? true : null,
+            Correspondent = HaveSeenCorrespondent ? true : null,
+            Captain = HaveSeenCaptain ? true : null,
+        };
+        zone.Entries.Add(e);
+        transactions.Add(zone);
+    }
+
+    public void RecordCombatBond(FactionKillBondEntry e) {
+        if (HighestCombatBond == null || e.Reward > HighestCombatBond) {
+            HighestCombatBond = e.Reward;
+        }
+
+        LastRecordedAwardingFaction = e.AwardingFaction;
+
+        if (IsOnFoot) {
+            ++OnFootKills;
+        } else {
+            ++ShipKills;
+        }
+    }
+
+    public void ResetCombatZone() {
+        HighestCombatBond = null;
+        HaveSeenCapShip = false;
+        HaveSeenCaptain = false;
+        HaveSeenCorrespondent = false;
+        HaveSeenSpecOps = false;
+        LastRecordedAwardingFaction = null;
+        OnFootKills = 0;
+        ShipKills = 0;
+        ThargoidInterceptorKills = 0;
+        ThargoidScoutKills = 0;
+        HaveSeenAXWarzoneNPC = false;
+    }
+
+    public void BoughtCargo(string? cargo, long? cost) {
+        if (cargo == null || cost == null) {
+            return;
+        }
+
+        BuyCost[cargo] = cost.Value;
+    }
+
+    public List<Faction>? GetFactions(string? system) {
+        if (system == null || !SystemFactions.ContainsKey(system)) {
+            return null;
+        }
+
+        return SystemFactions[system];
+    }
+
+    public void MissionAccepted(MissionAcceptedEntry? entry) {
+        if (entry == null) {
+            return;
+        }
+
+        MissionAccepted(entry.Mission);
+    }
+
+    public void MissionAccepted(Mission? mission) {
+        if (CurrentSystem == null || CurrentSystemAddress == null) {
+            throw new Exception("Mission accepted without knowing where.");
+        }
+
+        if (mission == null) {
+            throw new Exception("Mission is null");
+        }
+
+        AcceptedMissions.TryAdd(mission.MissionID, mission);
+
+        Location location = new() {
+            StarSystem = CurrentSystem,
+            SystemAddress = CurrentSystemAddress.Value,
+            Station = (CurrentStation ?? ""),
+        };
+
+        AcceptedMissionLocation.TryAdd(mission.MissionID, location);
+    }
+}

EDPlayerJournal/BGS/TransactionParserPart.cs

@@ -0,0 +1,19 @@
+using EDPlayerJournal.Entries;
+
+namespace EDPlayerJournal.BGS;
+
+internal interface ITransactionParserPart {
+    /// <summary>
+    /// Parse a given entry of the entry type specified when declaring to implement this
+    /// interface. You must add your transaction to the passed list in case you did have
+    /// enough information to parse one or more. You may update the parser context
+    /// with new information in case the entry yielded new information.
+    /// Throw an exception if there was an error or a malformed entry. If you have an
+    /// incomplete entry, i.e. not enough information to complete one, add an
+    /// IncompleteTransaction to the list
+    /// </summary>
+    /// <param name="entry">The entry to parse</param>
+    /// <param name="context">Parsing context that may contain useful information</param>
+    /// <param name="transactions">List of parsed transactions</param>
+    public void Parse(Entry entry, TransactionParserContext context, TransactionParserOptions options, TransactionList transactions);
+}

EDPlayerJournal/CombatZones.cs

@@ -43,7 +43,7 @@ public class CombatZones {
     /// Returns the given combat zone difficulty as an integer, so it can be sorted.
     /// 0 = lowest difficulty, 1 = medium and so forth.
     /// </summary>
-    public static int? DifficultyRank(string difficulty) {
+    public static int? DifficultyRank(string? difficulty) {
         Dictionary<string, int> ranks = new() {
             { DifficultyLow, 0 },
             { DifficultyMedium, 1 },
@@ -51,6 +51,10 @@ public class CombatZones {
             { DifficultyVeryHigh, 3 }
         };
 
+        if (difficulty == null ) {
+            return null;
+        }
+
         if (ranks.TryGetValue(difficulty, out int rank)) {
             return rank;
         }

EDPlayerJournal/EnglishMissionNames.cs

@@ -15,6 +15,7 @@ public class EnglishMissionNames {
         {"Mission_AltruismCredits_name", "Donate Credits"},
         {"Mission_AltruismCredits_Outbreak_name", "Donate Credits (Outbreak)" },
         {"Mission_Assassinate_Illegal_BLOPS_name", "Assassination (Illegal)"},
+        {"MISSION_assassinate_Illegal_Planetary_name", "Assassination (Illegal, Planetary)" },
         {"Mission_Assassinate_Legal_Bust_name", "Assassination (Bust, Legal)" },
         {"MISSION_assassinate_legal_CivilUnrest_name", "Assassination (Civil Unrest, Legal)" },
         {"Mission_Assassinate_Legal_Communism_name", "Assassination (Communism, Legal)" },
@@ -51,7 +52,10 @@ public class EnglishMissionNames {
         {"Mission_Delivery_Retreat_name", "Delivery (Retreat)"},
         {"Mission_DeliveryWing_name", "Delivery (Wing)"},
         {"Mission_DeliveryWing_War_name", "Delivery (Wing) (War)"},
-        {"MISSION_Disable_BLOPS_name", "Disable (Black Ops)" },
+        {"Mission_Disable_BLOPS_Expansion_name", "Disable Surface Installation (Expansion) (Black Ops)" },
+        {"MISSION_Disable_BLOPS_name", "Disable Surface Installation (Black Ops)" },
+        {"MISSION_Disable_name", "Disable Surface Installation" },
+        {"MISSION_Hack_name", "Hack Surface Installation" },
         {"Mission_Hack_BLOPS_Boom_name", "Hack Surface Installation (Boom)"},
         {"Mission_Hack_BLOPS_Elections_name", "Hack Surface Installation (Elections)"},
         {"Mission_Hack_BLOPS_Expansion_name", "Hack Surface Installation (Expansion)"},
@@ -100,8 +104,10 @@ public class EnglishMissionNames {
         {"Mission_PassengerVIP_name", "Passenger (VIP)"},
         {"Mission_PassengerVIP_Scientist_FAMINE_name", "Passenger Scientist (VIP) (Famine)"},
         {"Mission_PassengerVIP_Tourist_BOOM_name", "Passenger Tourist (VIP) (Boom)"},
-        {"Mission_Rescue_Planet_name", "Planet Rescue"},
+        {"Mission_Rescue_Elections_name", "Liberate Hostages (Election)" },
+        {"Mission_Rescue_name", "Liberate Hostages" },
         {"Mission_Rescue_Planet_Expansion_name", "Planet Rescue (Expansion)" },
+        {"Mission_Rescue_Planet_name", "Planet Rescue"},
         {"MISSION_Salvage_CivilUnrest_name", "Salvage (Civil Unrest)"},
         {"MISSION_Salvage_Expansion_name", "Salvage (Expansion)"},
         {"MISSION_Salvage_Illegal_name", "Salvage (Illegal)"},
@@ -119,7 +125,10 @@ public class EnglishMissionNames {
         {"Mission_TW_Massacre_Cyclops_Singular_name", "Kill Cyclop" },
         {"Mission_TW_Massacre_Hydra_Plural_name", "Kill Hydras" },
         {"Mission_TW_Massacre_Hydra_Singular_name", "Kill Hydra" },
+        {"Mission_TW_Massacre_Medusa_Plural_name", "Kill Medusas" },
+        {"Mission_TW_Massacre_Medusa_Singular_name", "Kill Medusa" },
         {"Mission_TW_Massacre_Scout_Plural_name", "Kill Scouts" },
+        {"Mission_TW_OnFoot_Reboot_Occupied_MB_name", "Reboot Settlement (Thargoid)" },
         {"Mission_TW_PassengerEvacuation_Burning_name", "Passenger Evacuation (Significant Damage)" },
         {"Mission_TW_PassengerEvacuation_UnderAttack_name", "Passenger Evacuation (Thargoid Invasion)" },
         {"Mission_TW_Rescue_UnderAttack_name", "Rescue (Thargoid Attack)" },

EDPlayerJournal/Entries/Entry.cs

@@ -44,6 +44,7 @@ public class Entry {
         { Events.SellOrganicData, typeof(SellOrganicDataEntry) },
         { Events.ShieldState, typeof(ShieldStateEntry) },
         { Events.ShipTargeted, typeof(ShipTargetedEntry) },
+        { Events.SupercruiseDestinationDrop, typeof(SupercruiseDestinationDropEntry) },
         { Events.SupercruiseEntry, typeof(SupercruiseEntryEntry) },
         { Events.SupercruiseExit, typeof(SupercruiseExitEntry) },
         { Events.UnderAttack, typeof(UnderAttackEntry) },

EDPlayerJournal/Entries/Events.cs

@@ -35,6 +35,7 @@ public class Events {
     public static readonly string ShieldState = "ShieldState";
     public static readonly string ShipTargeted = "ShipTargeted";
     public static readonly string Shutdown = "Shutdown";
+    public static readonly string SupercruiseDestinationDrop = "SupercruiseDestinationDrop";
     public static readonly string SupercruiseEntry = "SupercruiseEntry";
     public static readonly string SupercruiseExit = "SupercruiseExit";
     public static readonly string UnderAttack = "UnderAttack";

EDPlayerJournal/Entries/LocationEntry.cs

@@ -1,18 +1,47 @@
-using System;
+using Newtonsoft.Json.Linq;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-using Newtonsoft.Json.Linq;
 
 namespace EDPlayerJournal.Entries;
+
 public class LocationEntry : Entry {
+    /// <summary>
+    /// Current star system.
+    /// </summary>
     public string? StarSystem { get; set; }
+
+    /// <summary>
+    /// Faction in control of the current star system. Empty for unpopulated
+    /// systems.
+    /// </summary>
     public string? SystemFaction { get; set; }
-    public string? StationName { get; set; }
+
+    /// <summary>
+    /// 64bit system address.
+    /// </summary>
     public ulong SystemAddress { get; set; }
+
+    /// <summary>
+    /// Station name if docked at a station.
+    /// </summary>
+    public string? StationName { get; set; }
+
+    /// <summary>
+    /// Faction in control of the current station, if docked.
+    /// </summary>
+    public string? StationFaction { get; set; }
+
+    /// <summary>
+    /// Body within the system, might be null.
+    /// </summary>
     public string? Body { get; set; }
+
+    /// <summary>
+    /// Returns true if the player is docked somewhere.
+    /// </summary>
     public bool Docked { get; set; }
+
+    /// <summary>
+    /// Position of the star system.
+    /// </summary>
     public long[]? StarPos { get; set; }
 
     public List<Faction> SystemFactions { get; set; } = new List<Faction>();
@@ -30,7 +59,12 @@ public class LocationEntry : Entry {
 
         JObject? systemfaction = JSON.Value<JObject>("SystemFaction");
         if (systemfaction != null) {
-            SystemFaction = systemfaction.Value<string>("Name") ?? "";
+            SystemFaction = systemfaction.Value<string>("Name");
+        }
+
+        JObject? stationfaction = JSON.Value<JObject>("StationFaction");
+        if (stationfaction != null) {
+            StationFaction = stationfaction.Value<string>("Name");
         }
 
         JArray? factions = JSON.Value<JArray>("Factions");

EDPlayerJournal/Entries/SupercruiseDestinationDropEntry.cs

@@ -0,0 +1,30 @@
+namespace EDPlayerJournal.Entries;
+
+public class SupercruiseDestinationDropEntry : Entry {
+    /// <summary>
+    /// Destination type, internal string.
+    /// </summary>
+    public string? Type { get; set; } = null;
+
+    /// <summary>
+    /// Destination type, localised string.
+    /// </summary>
+    public string? TypeLocalised { get; set; } = null;
+
+    /// <summary>
+    /// Threat of the destination, if known.
+    /// </summary>
+    public long? Threat { get; set; } = null;
+
+    /// <summary>
+    /// Market ID if it has one.
+    /// </summary>
+    public ulong? MarketID { get; set; } = null;
+
+    protected override void Initialise() {
+        Type = JSON.Value<string>("Type");
+        TypeLocalised = JSON.Value<string>("Type_Localised");
+        Threat = JSON.Value<long?>("Threat");
+        MarketID = JSON.Value<ulong?>("MarketID");
+    }
+}

EDPlayerJournal/Faction.cs

@@ -55,6 +55,11 @@ public class Factions {
     /// </summary>
     public static string Thargoid = "Thargoids";
 
+    /// <summary>
+    /// The faction the fleet carriers use.
+    /// </summary>
+    public static string FleetCarrier = "FleetCarrier";
+
     public static bool IsPilotsFederation(string? name) {
         if (name == null) {
             return false;

EDPlayerJournal/Instances.cs

@@ -0,0 +1,73 @@
+namespace EDPlayerJournal;
+
+/// <summary>
+/// Contains information regarding instances you can supercruise into,
+/// such as combat zones, installations and megaship scenarios.
+/// </summary>
+public class Instances {
+    /// <summary>
+    /// Low ship combat zone
+    /// </summary>
+    public static readonly string WarzoneLow = "$Warzone_PointRace_Low";
+    /// <summary>
+    /// Medium ship combat zone
+    /// </summary>
+    public static readonly string WarzoneMedium = "$Warzone_PointRace_Med";
+    /// <summary>
+    /// High ship combat zone.
+    /// </summary>
+    public static readonly string WarzoneHigh = "$Warzone_PointRace_High";
+
+    /// <summary>
+    /// Low Thargoid combat zone
+    /// </summary>
+    public static readonly string WarzoneThargoidLow = "$Warzone_TG_Low";
+    /// <summary>
+    /// Medium Thargoid combat zone
+    /// </summary>
+    public static readonly string WarzoneThargoidMedium = "$Warzone_TG_Med";
+    /// <summary>
+    /// High Thargoid combat zone
+    /// </summary>
+    public static readonly string WarzoneThargoidHigh = "$Warzone_TG_High";
+    /// <summary>
+    /// Very High Thargoid combat zone
+    /// </summary>
+    public static readonly string WarzoneThargoidVeryHigh = "$Warzone_TG_VeryHigh";
+
+    public static bool IsThargoidWarzone(string type) {
+        return 
+            IsInstance(type, WarzoneThargoidLow) ||
+            IsInstance(type, WarzoneThargoidMedium) ||
+            IsInstance(type, WarzoneThargoidHigh) ||
+            IsInstance(type, WarzoneThargoidVeryHigh)
+            ;
+    }
+
+    public static bool IsHumanWarzone(string type) {
+        return 
+            IsInstance(type, WarzoneLow) ||
+            IsInstance(type, WarzoneMedium) ||
+            IsInstance(type, WarzoneHigh)
+            ;
+    }
+
+    public static bool IsWarzone(string type) {
+        return IsHumanWarzone(type) || IsThargoidWarzone(type);
+    }
+
+    public static bool IsInstance(string type, string instance) {
+        if (string.IsNullOrEmpty(type) || string.IsNullOrEmpty(instance)) {
+            return false;
+        }
+
+        // Instance names are split by a semi colon, with the remainder being
+        // additional info to such as index.
+        string[] parts = type.Split(":");
+        if (!parts[0].StartsWith("$")) {
+            return false;
+        }
+
+        return string.Compare(parts[0], instance, true) == 0;
+    }
+}

EDPlayerJournal/Thargoid.cs

@@ -8,6 +8,11 @@ public enum ThargoidVessel {
     Basilisk = 4,
     Medusa = 5,
     Hydra = 6,
+    Glaive = 7,
+    /// <summary>
+    /// Thargoid drone
+    /// </summary>
+    Revenant = 8,
 }
 
 public class Thargoid {
@@ -15,34 +20,41 @@ public class Thargoid {
 
     public static Dictionary<ulong, ThargoidVessel> VesselPayout { get; } = new() {
         // Up to date values ever since 14.02
+        {    25000, ThargoidVessel.Revenant },
         {    65000, ThargoidVessel.Scout },
         {    75000, ThargoidVessel.Scout },
+        // New in Update 15
+        {  4500000, ThargoidVessel.Glaive },
         {  6500000, ThargoidVessel.Cyclops },
         { 20000000, ThargoidVessel.Basilisk },
-        { 25000000, ThargoidVessel.Orthrus },
+        //{ 25000000, ThargoidVessel.Orthrus },
         { 34000000, ThargoidVessel.Medusa },
+        // March, 16th 2023 the Orthrus payout was buffed again.
+        { 40000000, ThargoidVessel.Orthrus },
         { 50000000, ThargoidVessel.Hydra },
         // These are the old values pre Update 14.02
-        {    80000, ThargoidVessel.Scout },
+        //{    80000, ThargoidVessel.Scout },
-        {  8000000, ThargoidVessel.Cyclops },
+        //{  8000000, ThargoidVessel.Cyclops },
-        { 24000000, ThargoidVessel.Basilisk },
+        //{ 24000000, ThargoidVessel.Basilisk },
         // In Update 14.1 the payout for Orthrus has been rebalanced.
-        { 30000000, ThargoidVessel.Orthrus },
+        //{ 30000000, ThargoidVessel.Orthrus },
-        { 40000000, ThargoidVessel.Medusa },
+        //{ 40000000, ThargoidVessel.Medusa },
         // This used to be the old payout value for Orthrus, it now conflicts
         // with Post Update 14.02 Hydra values
         //{ 50000000, ThargoidVessel.Orthrus },
-        { 60000000, ThargoidVessel.Hydra },
+        //{ 60000000, ThargoidVessel.Hydra },
     };
 
     public static Dictionary<ThargoidVessel, string?> VesselNames { get; } = new() {
         { ThargoidVessel.Unknown, null },
-        { ThargoidVessel.Scout, "Thargoid Scout" },
+        { ThargoidVessel.Revenant, "Revenant" },
+        { ThargoidVessel.Scout, "Scout" },
         { ThargoidVessel.Orthrus, "Orthrus" },
         { ThargoidVessel.Cyclops, "Cyclops" },
         { ThargoidVessel.Basilisk, "Basilisk" },
         { ThargoidVessel.Medusa, "Medusa" },
         { ThargoidVessel.Hydra, "Hydra" },
+        { ThargoidVessel.Glaive, "Glaive" },
     };
 
     public static ThargoidVessel GetVesselByPayout(ulong payout) {

EliteBGS/DiscordLogGenerator.cs

@@ -19,8 +19,7 @@ public class DiscordLogGenerator {
         new MicroResourcesFormat(),
         new MarketBuyFormat(),
         new CargoSoldFormatter(),
-        /* As of this moment, Update 14.02 organics do not affect BGS at all */
+        new VistaGenomicsFormat(),
-        //new VistaGenomicsFormat(),
         new SearchAndRescueFormat(),
     };
 
@@ -40,7 +39,7 @@ public class DiscordLogGenerator {
             }
 
             if (sb.Length > 0) {
-                sb.Append(", ");
+                sb.Append("; ");
             }
 
             sb.Append(summary);

EliteBGS/EliteBGS.csproj

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <TargetFramework>net7.0-windows</TargetFramework>
     <OutputType>WinExe</OutputType>
-    <Version>0.3.0</Version>
+    <Version>0.3.3</Version>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
     <UseWindowsForms>true</UseWindowsForms>
     <UseWPF>true</UseWPF>
@@ -54,12 +54,6 @@
   <ItemGroup>
     <Resource Include="Salus.ico" />
   </ItemGroup>
-  <ItemGroup>
-    <Resource Include="Resources\EliteBGS.ico" />
-  </ItemGroup>
-  <ItemGroup>
-    <Resource Include="EliteBGS.ico" />
-  </ItemGroup>
   <ItemGroup>
     <PackageReference Include="MahApps.Metro" Version="2.4.9" />
     <PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
@@ -85,4 +79,7 @@
       <LastGenOutput>Resources.Designer.cs</LastGenOutput>
     </EmbeddedResource>
   </ItemGroup>
+  <ItemGroup>
+    <Folder Include="Resources\" />
+  </ItemGroup>
 </Project>

EliteBGS/LogGenerator/CargoSoldFormatter.cs

@@ -58,11 +58,20 @@ public class CargoSoldFormatter : LogFormatter {
     public string GenerateSummary(Objective objective) {
         SellCargo[] sold = objective.EnabledOfType<SellCargo>().ToArray();
         long totalProfit = sold.Sum(x => x.Profit);
+        long tons = sold.Sum(x => x.Amount);
 
-        if (totalProfit >= 100000) {
+        if (tons <= 0) {
-            return string.Format("Trade: {0}", Credits.FormatMillions(totalProfit));
+            return "";
         }
 
-        return "";
+        StringBuilder builder = new();
+
+        builder.Append("Sold: ");
+        builder.AppendFormat("{0}t", tons);
+        if (totalProfit >= 100000) {
+            builder.AppendFormat(", {0} profit", Credits.FormatMillions(totalProfit));
+        }
+
+        return builder.ToString();
     }
 }

EliteBGS/LogGenerator/CombatZoneFormat.cs

@@ -9,7 +9,7 @@ class CombatZoneFormat : LogFormatter {
     public string GenerateLog(Objective objective) {
         var logs = objective
             .EnabledOfType<CombatZone>()
-            .OrderBy(x => CombatZones.DifficultyRank(x.Grade))
+            .OrderBy(x => (CombatZones.DifficultyRank(x.Grade) ?? 0))
             .GroupBy(x => new { x.Type, x.Grade })
             .ToDictionary(x => x.Key, x => x.ToList())
             ;
@@ -48,7 +48,7 @@ class CombatZoneFormat : LogFormatter {
     public string GenerateSummary(Objective objective) {
         var logs = objective
             .EnabledOfType<CombatZone>()
-            .OrderBy(x => CombatZones.DifficultyRank(x.Grade))
+            .OrderBy(x => (CombatZones.DifficultyRank(x.Grade) ?? 0))
             .GroupBy(x => new { x.Type, x.Grade })
             .ToDictionary(x => x.Key, x => x.ToList())
             ;
@@ -72,7 +72,7 @@ class CombatZoneFormat : LogFormatter {
                 }
                 builder.AppendFormat("CZ: {0}x{1}{2}",
                     log.Value.Count,
-                    log.Key.Grade.Substring(0, 1),
+                    grade,
                     log.Key.Type.Substring(0, 1)
                     );
             } else {

EliteBGS/LogGenerator/FailedMissionFormat.cs

@@ -43,12 +43,13 @@ public class FailedMissionFormat : LogFormatter {
         int onFootFails = missions.Where(x => x.Mission.IsOnFoot).Count();
         int shipFails = missions.Where(x => !x.Mission.IsOnFoot).Count();
 
+        sb.Append("Fails: ");
         if (onFootFails > 0) {
-            sb.AppendFormat("Fails: {0} Ground", onFootFails);
+            sb.AppendFormat("{0} Ground", onFootFails);
         }
 
         if (shipFails > 0) {
-            if (sb.Length> 0) {
+            if (onFootFails > 0) {
                 sb.Append(", ");
             }
             sb.AppendFormat("{0} Ship", shipFails);

EliteBGS/LogGenerator/GenericFormat.cs

@@ -26,7 +26,7 @@ public class GenericFormat<Type> : LogFormatter where Type : Transaction {
         return builder.ToString();
     }
 
-    public string GenerateSummary(Objective objective) {
+    public virtual string GenerateSummary(Objective objective) {
         throw new System.NotImplementedException();
     }
 }

EliteBGS/LogGenerator/KillBondsFormat.cs

@@ -1,6 +1,38 @@
-using EDPlayerJournal.BGS;
+using EDPlayerJournal;
+using EDPlayerJournal.BGS;
+using System.Linq;
+using System.Text;
 
 namespace EliteBGS.LogGenerator;
 
 public class KillBondsFormat : GenericFormat<FactionKillBonds> {
+    public override string GenerateSummary(Objective objective) {
+        StringBuilder builder = new StringBuilder();
+
+        var bonds = objective
+            .EnabledOfType<FactionKillBonds>()
+            .GroupBy(x => x.VictimFaction)
+            .ToDictionary(x => x.Key, x => x.ToList())
+            ;
+
+        if (bonds.Count <= 0) {
+            return "";
+        }
+
+        builder.Append("Killbonds: ");
+        foreach (var entry in bonds) {
+            long sum = (long)entry.Value.Sum(x => (decimal)x.TotalSum);
+            builder.AppendFormat("{0} against {1}, ",
+                    Credits.FormatMillions(sum),
+                    entry.Key
+                );
+        }
+
+        if (builder.Length > 2) {
+            // Remove trailing comma
+            builder.Remove(builder.Length - 2, 2);
+        }
+
+        return builder.ToString();
+    }
 }

EliteBGS/LogGenerator/MarketBuyFormat.cs

@@ -1,6 +1,17 @@
 using EDPlayerJournal.BGS;
+using System.Linq;
 
 namespace EliteBGS.LogGenerator;
 
 public class MarketBuyFormat : GenericFormat<BuyCargo> {
+    public override string GenerateSummary(Objective objective) {
+        long tons = objective
+            .EnabledOfType<BuyCargo>()
+            .Sum(x => x.Amount)
+            ;
+        if (tons <= 0) {
+            return "";
+        }
+        return string.Format("Bought: {0}t", tons);
+    }
 }

EliteBGS/LogGenerator/MurderFormat.cs

@@ -1,9 +1,7 @@
-using EDPlayerJournal.BGS;
+using EDPlayerJournal;
-using System.Collections.Generic;
+using EDPlayerJournal.BGS;
 using System.Text;
-using System;
 using System.Linq;
-using EDPlayerJournal;
 
 namespace EliteBGS.LogGenerator;
 
@@ -36,14 +34,14 @@ public class MurderFormat : LogFormatter {
                     type = "person";
                 }
             }
-            builder.AppendFormat("Murdered {0} {1} (Bounties: {2}, Fines: {3})",
+            long bounties = log.Value.Sum(x => x.Bounties);
+            builder.AppendFormat("Murdered {0} {1} (Bounties: {2})\n",
                 log.Value.Count, type,
-                log.Value.Sum(x => x.Bounties),
+                Credits.FormatMillions(bounties)
-                log.Value.Sum(x => x.Fines)
                 );
         }
 
-        return builder.ToString();
+        return builder.ToString().Trim();
     }
 
     public string GenerateSummary(Objective objective) {

EliteBGS/LogGenerator/SearchAndRescueFormat.cs

@@ -1,6 +1,22 @@
-using EDPlayerJournal.BGS;
+using EDPlayerJournal;
+using EDPlayerJournal.BGS;
+using System.Linq;
 
 namespace EliteBGS.LogGenerator;
 
 public class SearchAndRescueFormat : GenericFormat<SearchAndRescue> {
+    public override string GenerateSummary(Objective objective) {
+        long tons = objective
+            .EnabledOfType<SearchAndRescue>()
+            .Sum(x => x.Count)
+            ;
+        long profit = objective
+            .EnabledOfType<SearchAndRescue>()
+            .Sum(x => x.Reward)
+            ;
+        if (tons <= 0) {
+            return "";
+        }
+        return string.Format("S&R: {0}t, {1} profit", tons, Credits.FormatMillions(profit));
+    }
 }

EliteBGS/LogGenerator/ThargoidFormatter.cs

@@ -37,8 +37,9 @@ public class ThargoidFormatter : LogFormatter {
             return "";
         }
 
+        int drones = kills.Where(x => x.ThargoidType == ThargoidVessel.Revenant).Count();
         int scouts = kills.Where(x => x.ThargoidType == ThargoidVessel.Scout).Count();
-        int interceptors = kills.Count - scouts;
+        int interceptors = kills.Count - scouts - drones;
 
         StringBuilder builder = new StringBuilder();
 
@@ -47,11 +48,17 @@ public class ThargoidFormatter : LogFormatter {
             builder.AppendFormat("{0} INT", interceptors);
         }
         if (scouts > 0) {
-            if (builder.Length> 0) {
+            if (interceptors > 0) {
                 builder.Append(", ");
             }
             builder.AppendFormat("{0} SCT", scouts);
         }
+        if (drones > 0) {
+            if (interceptors > 0 || scouts > 0) {
+                builder.Append(", ");
+            }
+            builder.AppendFormat("{0} DRN", drones);
+        }
 
         return builder.ToString();
     }

EliteBGS/LogGenerator/VistaGenomicsFormat.cs

@@ -1,6 +1,18 @@
-using EDPlayerJournal.BGS;
+using EDPlayerJournal;
+using EDPlayerJournal.BGS;
+using System.Linq;
 
 namespace EliteBGS.LogGenerator;
 
 class VistaGenomicsFormat : GenericFormat<OrganicData> {
+    public override string GenerateSummary(Objective objective) {
+        long profit = objective
+            .EnabledOfType<OrganicData>()
+            .Sum(x => x.TotalValue)
+            ;
+        if (profit <= 0) {
+            return "";
+        }
+        return string.Format("Organic: {0} Profit", Credits.FormatMillions(profit));
+    }
 }

EliteBGS/LogGenerator/VoucherFormat.cs

@@ -19,8 +19,8 @@ public class VoucherFormat : LogFormatter {
         }
 
         foreach (var m in missions) {
-            ulong total = (ulong)m.Value.Sum(x => (decimal)x.TotalSum);
+            long total = (long)m.Value.Sum(x => (decimal)x.TotalSum);
-            builder.AppendFormat("Handed in {0} vouchers: {1}\n", m.Key, Credits.FormatCredits(total));
+            builder.AppendFormat("Handed in {0} vouchers: {1}\n", m.Key, Credits.FormatMillions(total));
         }
 
         return builder.ToString().Trim();

EliteBGS/MainWindow.xaml

@@ -163,6 +163,7 @@
             <TabItem Header="Settings">
                 <Grid>
                     <Grid.RowDefinitions>
+                        <RowDefinition Height="Auto"/>
                         <RowDefinition Height="Auto"/>
                         <RowDefinition Height="Auto"/>
                         <RowDefinition Height="*"/>
@@ -181,10 +182,13 @@
                             <Grid.ColumnDefinitions>
                                 <ColumnDefinition Width="*"/>
                                 <ColumnDefinition Width="Auto"/>
+                                <ColumnDefinition Width="Auto"/>
+                                <ColumnDefinition Width="Auto"/>
                             </Grid.ColumnDefinitions>
                             <Label Content="Location on disk for the player journal. There is usually no need to change this setting." Grid.Row="0" Grid.ColumnSpan="2" HorizontalAlignment="Left" Margin="0,0,0,0" VerticalAlignment="Top" RenderTransformOrigin="-0.08,0.496"/>
                             <TextBox x:Name="journallocation" IsReadOnly="true" Text="" Grid.Row="1" Grid.Column="0" Margin="5,0,5,10" TextWrapping="Wrap" />
                             <Button x:Name="browsejournallocation" Content="Browse" Grid.Row="1" Grid.Column="1" Margin="0,0,0,0" Width="Auto" VerticalAlignment="Top" HorizontalAlignment="Left" Click="browsejournallocation_Click"/>
+                            <Button x:Name="OpenInExplorer" Content="Open Folder" Grid.Row="1" Grid.Column="2" Margin="5,0,0,0" Width="Auto" VerticalAlignment="Top" HorizontalAlignment="Left" Click="OpenInExplorer_Click" />
                         </Grid>
                     </GroupBox>
                     <GroupBox Header="Theme Colour" Height="Auto" Grid.Row="1" VerticalAlignment="Top" Width="Auto" Grid.ColumnSpan="3" Margin="0,5,0,0">
@@ -201,6 +205,22 @@
                             <ComboBox x:Name="Colour" IsEditable="False" Grid.Row="1" Grid.Column="0" VerticalAlignment="Center" Width="Auto" SelectionChanged="Colour_SelectionChanged"/>
                         </Grid>
                     </GroupBox>
+                    <GroupBox Header="Advanced Parsing Options" Grid.Row="2" VerticalAlignment="Top" Width="Auto" Grid.ColumnSpan="3" Margin="0,5,0,0">
+                        <Grid>
+                            <Grid.RowDefinitions>
+                                <RowDefinition Height="Auto"/>
+                                <RowDefinition Height="Auto"/>
+                                <RowDefinition Height="Auto"/>
+                            </Grid.RowDefinitions>
+                            <Grid.ColumnDefinitions>
+                                <ColumnDefinition Width="*"/>
+                                <ColumnDefinition Width="Auto"/>
+                            </Grid.ColumnDefinitions>
+                            <mah:ToggleSwitch x:Name="NoInfluenceSupport" Grid.Row="0" Grid.ColumnSpan="2" Content="Ignore secondary influence support given out by certain missions" Toggled="NoInfluenceSupport_Toggled"/>
+                            <mah:ToggleSwitch x:Name="NoMarketBuy" Grid.Row="1" Grid.ColumnSpan="2" Content="Ignore commodities bought at stations" Toggled="NoMarketBuy_Toggled"/>
+                            <mah:ToggleSwitch x:Name="NoFleetCarrier" Grid.Row="2" Grid.ColumnSpan="2" Content="Ignore transactions done on a Fleet Carrier" Toggled="NoFleetCarrier_Toggled" />
+                        </Grid>
+                    </GroupBox>
                 </Grid>
             </TabItem>
             <TabItem Header="Event Log">

EliteBGS/MainWindow.xaml.cs

@@ -58,6 +58,10 @@ public partial class MainWindow : MetroWindow {
             LogType.SelectedIndex = 0;
         }
 
+        this.NoInfluenceSupport.IsOn = Config.Global.IgnoreInfluenceSupport;
+        this.NoMarketBuy.IsOn = Config.Global.IgnoreMarketBuy;
+        this.NoFleetCarrier.IsOn = Config.Global.IgnoreFleetCarrier;
+
         // Apply theme
         try {
             AddCustomThemes();
@@ -165,8 +169,14 @@ public partial class MainWindow : MetroWindow {
 
     private void HandleEntries(List<Entry> entries, DateTime start, DateTime end) {
         try {
-            TransactionParser parser = new TransactionParser();
+            TransactionParser parser = new();
-            List<Transaction> transactions = parser.Parse(entries);
+            TransactionParserOptions options = new();
+
+            options.IgnoreInfluenceSupport = Config.Global.IgnoreInfluenceSupport;
+            options.IgnoreMarketBuy = Config.Global.IgnoreMarketBuy;
+            options.IgnoreFleetCarrierFaction = Config.Global.IgnoreFleetCarrier;
+
+            List<Transaction> transactions = parser.Parse(entries, options);
 
             // Filter the transactions down to the given time frame
             transactions = transactions
@@ -271,7 +281,7 @@ public partial class MainWindow : MetroWindow {
         }
     }
 
-    private void entries_KeyUp(object sender, System.Windows.Input.KeyEventArgs e) {
+    private void entries_KeyUp(object sender, KeyEventArgs e) {
         if (e.Key == Key.Delete) {
             RemoveCurrentObjective();
         }
@@ -290,7 +300,7 @@ public partial class MainWindow : MetroWindow {
     }
 
     private Objective GetObjectiveFromControl(object sender) {
-        System.Windows.Controls.Control control = sender as System.Windows.Controls.Control;
+        Control control = sender as Control;
         if (control == null || control.DataContext == null) {
             return null;
         }
@@ -355,7 +365,7 @@ public partial class MainWindow : MetroWindow {
         try {
             Config.SaveGlobal();
         } catch (Exception error) {
-            System.Windows.MessageBox.Show("There was an error saving your settings: " + error.Message);
+            MessageBox.Show("There was an error saving your settings: " + error.Message);
         }
     }
 
@@ -363,7 +373,7 @@ public partial class MainWindow : MetroWindow {
     }
 
     private TransactionType GetTransaction<TransactionType>(object sender) where TransactionType : Transaction {
-        System.Windows.Controls.Control button = sender as System.Windows.Controls.Control;
+        Control button = sender as Control;
         if (button == null || button.DataContext == null) {
             return null;
         }
@@ -520,4 +530,25 @@ public partial class MainWindow : MetroWindow {
         Process.Start(info);
         e.Handled = true;
     }
+
+    private void NoInfluenceSupport_Toggled(object sender, RoutedEventArgs e) {
+        Config.Global.IgnoreInfluenceSupport = this.NoInfluenceSupport.IsOn;
+    }
+
+    private void NoMarketBuy_Toggled(object sender, RoutedEventArgs e) {
+        Config.Global.IgnoreMarketBuy = this.NoMarketBuy.IsOn;
+    }
+
+    private void NoFleetCarrier_Toggled(object sender, RoutedEventArgs e) {
+        Config.Global.IgnoreFleetCarrier = this.NoFleetCarrier.IsOn;
+    }
+
+    private void OpenInExplorer_Click(object sender, RoutedEventArgs e) {
+        try {
+            Process.Start(new ProcessStartInfo(Config.Global.JournalLocation) {
+                UseShellExecute = true,
+            });
+        } catch (Exception) {
+        }
+    }
 }

EliteBGS/OneLineDiscordLog.cs

@@ -1,4 +1,8 @@
-namespace EliteBGS;
+using EliteBGS.LogGenerator;
+using System.Linq;
+using System.Text;
+
+namespace EliteBGS;
 
 public class OneLineDiscordLog : DiscordLogGenerator {
     protected override string GenerateObjectiveHeader(Objective objective) {
@@ -10,7 +14,7 @@ public class OneLineDiscordLog : DiscordLogGenerator {
     }
 
     protected override string GenerateObjectiveFooter(Objective objective) {
-        return "";
+        return "\n";
     }
 
     protected override string GenerateFooter() {
@@ -21,9 +25,38 @@ public class OneLineDiscordLog : DiscordLogGenerator {
         return "";
     }
 
-    protected override string TransformFinalLogForObjective(Objective objective, string log) {
+    public override string GenerateDiscordLog(Report report) {
-        string[] lines = log.Split("\n", System.StringSplitOptions.RemoveEmptyEntries);
+        StringBuilder log = new StringBuilder();
-        return string.Join(", ", lines);
+
+        if (report == null) {
+            return "";
+        }
+
+        var objectives = report.Objectives
+            .Where(x => x.IsEnabled && x.Transactions.Count() > 0)
+            ;
+
+        if (objectives == null || objectives.Count() <= 0) {
+            return "";
+        }
+
+        foreach (Objective objective in objectives) {
+            log.AppendFormat("{0}", GenerateObjectiveHeader(objective));
+
+            foreach (LogFormatter formatter in formatters) {
+                string text = formatter.GenerateSummary(objective);
+                text = text.Trim();
+                if (!string.IsNullOrEmpty(text)) {
+                    log.AppendFormat("{0}; ", text);
+                }
+            }
+
+            log.AppendFormat("{0}", GenerateObjectiveFooter(objective));
+        }
+
+        log.AppendFormat("{0}", GenerateFooter());
+
+        return log.ToString().Trim();
     }
 
     public override string ToString() {

EliteBGS/Properties/AssemblyInfo.cs

@@ -51,5 +51,5 @@ using System.Windows;
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("0.1.1.0")]
+[assembly: AssemblyVersion("0.3.3.0")]
-[assembly: AssemblyFileVersion("0.1.1.0")]
+[assembly: AssemblyFileVersion("0.3.3.0")]

EliteBGS/Properties/Resources.resx

@@ -117,8 +117,4 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
-  <assembly alias="System.Windows.Forms" name="System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
-  <data name="EliteBGS" type="System.Resources.ResXFileRef, System.Windows.Forms">
-    <value>..\EliteBGS.ico;System.Drawing.Icon, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
-  </data>
 </root>

EliteBGS/Resources.Designer.cs

@@ -60,16 +60,6 @@ namespace EliteBGS {
             }
         }
         
-        /// <summary>
-        ///   Looks up a localized resource of type System.Drawing.Icon similar to (Icon).
-        /// </summary>
-        public static System.Drawing.Icon EliteBGS {
-            get {
-                object obj = ResourceManager.GetObject("EliteBGS", resourceCulture);
-                return ((System.Drawing.Icon)(obj));
-            }
-        }
-        
         /// <summary>
         ///   Looks up a localized resource of type System.Drawing.Bitmap.
         /// </summary>

EliteBGS/Resources.resx

@@ -118,9 +118,6 @@
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
   <assembly alias="System.Windows.Forms" name="System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
-  <data name="EliteBGS" type="System.Resources.ResXFileRef, System.Windows.Forms">
-    <value>EliteBGS.ico;System.Drawing.Icon, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
-  </data>
   <data name="logo_v5" type="System.Resources.ResXFileRef, System.Windows.Forms">
     <value>logo_v5.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
   </data>

EliteBGS/Util/AppConfig.cs

@@ -48,6 +48,21 @@ namespace EliteBGS.Util {
             }
         }
 
+        /// <summary>
+        /// Whether we ignore influence support scenarios form parsing.
+        /// </summary>
+        public bool IgnoreInfluenceSupport { get; set; } = false;
+
+        /// <summary>
+        /// Whether we ignore market buy entries during parsing.
+        /// </summary>
+        public bool IgnoreMarketBuy { get; set; } = false;
+
+        /// <summary>
+        /// Whether to ignore fleet carrier stuff when parsing.
+        /// </summary>
+        public bool IgnoreFleetCarrier { get; set; } = true;
+
         [JsonIgnore]
         public string FullTheme {
             get { return Theme + "." + Colour; }

EliteBGS/Util/Config.cs

@@ -36,6 +36,7 @@ namespace EliteBGS.Util {
                 filestream.Flush();
                 using (StreamWriter file = new StreamWriter(filestream, Encoding.UTF8)) {
                     var stream = new JsonTextWriter(file);
+                    stream.Formatting = Formatting.Indented;
                     serializer.Serialize(stream, global_config);
                 }
             }

EliteBGS/docs/CHANGELOG.md

@@ -1,5 +1,41 @@
 # EliteBGS changelog
 
+## 0.3.3 on 15.05.2023
+
+* Added payout for the Thargoid Glaive.
+* Added payout and support for the Thargoid Revenant.
+* Added more English mission names.
+* Ship and AX combat zones can now be detected through a new event, which
+  allows the tool to properly determine the difficulty. Combat zone outcome,
+  additional objectives, or the name of the factions fighting are still guess
+  work however.
+* Fixed a bug where newly added factions to a system weren't properly
+  recognised. Thanks to Shakaka.
+* Added option to ignore FleetCarrier actions.
+* Added an "Open in Explorer" button to journal locations.
+
+## 0.3.2 on 19.04.2023
+
+* Orthrus payout has been adapted to 14.02 values.
+* Old Thargoid payout values have been removed, so very old logs now no
+  longer parse correctly. The old value clashed with new ones, making
+  detection of interceptor kills difficult.
+* Fixed a problem regarding the proper detection of station owner, and
+  thus for whom the tool attributed market buy and market sell.
+* Added GUI options to ignore some less important BGS entries.
+* One line report has changed to show summaries
+* Summaries have been streamlined:
+  * semi-colons now separate entries
+  * missing BGS actions (like S&R) have received a summary
+  * Trade has been renamed to "Sold" and "Bought"
+  * Sold now shows tons of cargo sold, plus profit if available
+  * Bought shows tons of cargo bought
+
+## 0.3.1 on 26.02.2023
+
+* Fixed: AX combat zones caused crashes with the summary.
+* Fixed: Summaries for thargoid kills didn't render probably.
+
 ## 0.3.0 on 26.02.2023
 
 * Move to MahApps toolkit, which replaces extended toolkit.

EliteBGS/docs/faq.md

@@ -68,6 +68,9 @@ The time span you specify must include the day where you accepted the mission,
 as well as the day where you failed the mission. Otherwise the tool cannot handle
 that failed mission.
 
+Prior to update 15 missions only failed once you dismissed them from your transaction
+tab. With update 15, this behaviour should be fixed.
+
 ### The tool complains about missing factions for an NPC I murdered.
 
 The player journal only tells the faction that issued the bounty upon murder, and

EliteBGS/docs/index.md

@@ -20,13 +20,13 @@ command line:
 winget install Microsoft.DotNet.DesktopRuntime.7
 ```
 
-You can download the **latest** version **0.3.0** at CodeBerg:
+You can download the **latest** version **0.3.3** at CodeBerg:
 
 * [https://codeberg.org/nola/EDBGS/releases](https://codeberg.org/nola/EDBGS/releases)
 
 Or alternatively from my server:
 
-* [https://bgs.n0la.org/elitebgs-0.3.0.zip](https://bgs.n0la.org/elitebgs-0.3.0.zip)
+* [https://bgs.n0la.org/elitebgs-0.3.3.zip](https://bgs.n0la.org/elitebgs-0.3.3.zip)
 
 ## Old Versions